-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the modal mostly its own thing #2254
Conversation
….org into modal-spinoff
….org into modal-spinoff
@mavis I folded the "moving the react-ga-proxy" into this PR mostly because it affects the modal directly. |
I've also updated the main page modal to use the "for now" phrasing mentioned in #2250 (comment) /cc @kristinashu |
Yeah let's run will this that copy for now! Looks like the pink button is less round in this version than on Privacy Not Included? Can you make the ends fully rounded? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neattt! ✨ Please merge this PR after fixing donate button's border radius!
@kristinashu I fixed the button roundness plus adjusted button text from 14px to 16px as per mockup. |
Looks good, thanks! |
Closes #2252, closes #2250, when copy changes have been made.
Note: the donate modal text is not tailored to the foundation site itself at all yet, so in terms of testing. Uncomment https://github.com/mozilla/foundation.mozilla.org/pull/2254/files#diff-bcb353d4a212e3c287b0d8d8c377f1c5R325 and then: