Consolidate to single .env #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cadecairos – I'm guessing this might require some deployment tweaking? |
|
nope, this shouldn't affect the deployment - environments on Heroku are applied to the container automatically, not via FS |
cadecairos
reviewed
Aug 29, 2017
| SOCIAL_AUTH_GOOGLE_OAUTH2_SECRET= | ||
| SOCIAL_AUTH_LOGIN_REDIRECT_URL=http://localhost:5000/soc/complete/google-oauth2/ | ||
|
|
||
| # CSP config |
There was a problem hiding this comment.
does our env loader understand comments, since this isn't a bash-style source call?
There was a problem hiding this comment.
It seems to. On the build system side it converts to JSON and just ignores comments as expected.
cadecairos
approved these changes
Aug 30, 2017
gvn
added a commit
that referenced
this pull request
Sep 18, 2017
* consolidating env to single instance in root * domain tweak
gvn
added a commit
that referenced
this pull request
Sep 18, 2017
* consolidating env to single instance in root * domain tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #701