Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

left aligned buttons to text content on article pages #7813

Merged
merged 5 commits into from
Nov 9, 2021

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Nov 9, 2021

Closes #7788
Related PRs/issues #

Link to test page: foundation-s-article-bu-slc7zt.mofostaging.net/en/publication-page-with-child-article-pages/child-paper-else/

Steps to test:

  1. Please visit the testing site above
  2. Scroll to find the button saying "View the minimum election standards"
  3. It should be left aligned with the rest of the text.
  4. It should also wrap so all the text stays on the page throughout breakpoints
  5. If it is behaving as expected, testing is complete!

Percy Screenshots:

Showing the difference between running off-screen on mobile and now wrapping to show all content
image

Showing that there are no differences to buttons otherwise:
image

@mofodevops mofodevops temporarily deployed to foundation-s-article-bu-slc7zt November 9, 2021 00:44 Inactive
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-article-bu-slc7zt November 9, 2021 00:50 Inactive
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This PR introduces visual differences. Click here to inspect the diffs.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@Pomax
Copy link
Contributor

Pomax commented Nov 9, 2021

@danielfmiranda I assume this isn't WIP anymore =)

Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Pomax Pomax changed the title WIP: left aligned buttons to text content on article pages left aligned buttons to text content on article pages Nov 9, 2021
@danielfmiranda danielfmiranda temporarily deployed to foundation-s-article-bu-slc7zt November 9, 2021 17:34 Inactive
@Pomax Pomax merged commit e0716fc into main Nov 9, 2021
@Pomax Pomax deleted the article-button-alignment branch November 9, 2021 17:34
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This PR introduces visual differences. Click here to inspect the diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link buttons on articles are misaligned
4 participants