Fix #798: Removed signal related files and depentant methods + rebased master, rebranched and redone changes.

[jayyyin]

most up to date changes for removing the signal related files

[jayyyin]

original pull request here #825

[alanmoo]

Thanks for the update! @cadecairos or @patjouk can you take a look at this over the next few days and merge it in if it's all set?

[cadecairos]

Almost there @jayyyin, we just need to also remove the signals in the milestones app.

network-api/networkapi/milestones/signals.py should be removed, as well as network-api/networkapi/milestones/apps.py

[jayyyin]

@cadecairos yep just removed them, must have missed them when I removed the other ones

[cadecairos]

I apologize that I didn't catch this before, but we also need to remove all the related setting from settings.py

Specifically these lines:

1. here
2. here
3. here

[jayyyin]

@cadecairos np, I just removed the specified settings, should the rest of the HEROKU api stuff I see in there be touched? is that the name of the old api?

[cadecairos]

should the rest of the HEROKU api stuff I see in there be touched? is that the name of the old api?

Thanks for bringing this up, we need to keep this block, because it enables review apps to work properly. This means we should add back in this line, which served two purposes before, but is still needed.

[jayyyin]

@cadecairos alright thanks for the info, and I've added the line back in, should be good to go now from what I can tell.

[cadecairos]

Thanks so much for the PR @jayyyin!

[jayyyin]

@cadecairos Thank you!, it's been a pleasure.