This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Hide YouTube's "Full screen is unavailable" disclaimer when Fullscreen 360 Media Controls opened #1056
Assignees
Labels
Milestone
Comments
cvan
added
enhancement
MortimerGoro
pushed a commit
that referenced
this issue
Apr 11, 2019
…, `quality=` query-string parameter) (fixes issue #1051) (#1052) * tidy up YouTube WebCompat WebExtension (follow up to PR #1047) * automatically upgrade default YouTube video playback quality to HD 1440p (fixes issue #1051); hide `Full screen is unavailable` message (fixes issue #1056) - or via `vq=`/`query=` query-string parameter in URLs for youtube.com and youtube-nocookie.com * Fix SyntaxError * Update to wait until player has resolutions available
This was referenced May 14, 2019
|
I have fixed this locally and will make a PR shortly. so, my bad: this was supposed to be fixed in PR #1052, but Firefox chokes on the syntax error in the style selector here https://github.com/MozillaReality/FirefoxReality/pull/1052/files#r283601515, which causes the |
philip-lamb
pushed a commit
that referenced
this issue
May 16, 2019
…ube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056) (#1217) * YouTube improvements: enter 360 VR without having to first click YouTube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056) * toggle HD-quality helper + 360°-playback improvements when using YouTube's Single-Page-App navigation (vs. synchonrous page loads)
philip-lamb
pushed a commit
that referenced
this issue
May 16, 2019
…ube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056) (#1217) * YouTube improvements: enter 360 VR without having to first click YouTube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056) * toggle HD-quality helper + 360°-playback improvements when using YouTube's Single-Page-App navigation (vs. synchonrous page loads)
|
Fixed in #1217. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hardware
All
Steps to Reproduce
Full screen is unavailable. Learn MoreCurrent Behavior
A disclaimer appears in the bottom-right corner of YouTube videos when fullscreened before entering a projection:
Full screen is unavailable. Learn MoreExpected Behavior
As
Full screen is unavailable. Learn Moredisclaimer is confusing and unnecessary, it should not appear in the bottom-right corner of YouTube videos when fullscreened before entering a projection.Possible Solution
We informed YouTube of this WebCompat issue a while back, but there's been no response. In the meantime, FxR can hide this disclaimer with its YouTube Web Extension content script, which was added in PR #1047 and improved upon in PR #1052.
The text was updated successfully, but these errors were encountered: