Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Upgrade to Mozilla Android Component v.19. #2089

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Upgrade to Mozilla Android Component v.19. #2089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fabc510
Upgrade to A-C v.19.
daoshengmu Oct 28, 2019
8ea480d
Glean configuration can't call its constructor after updating to AC19.
daoshengmu Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/src/common/shared/org/mozilla/vrbrowser/telemetry/GleanMetricsService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ public static void init(Context aContext) {
} else {
GleanMetricsService.stop();
}
Configuration config = new Configuration(Configuration.DEFAULT_TELEMETRY_ENDPOINT,
BuildConfig.BUILD_TYPE);
Configuration config = new Configuration();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just fixed in mozilla-mobile/android-components#4892. @pocmo is cutting a new Android Components 19 dot release today, so you'll be able to jump to the new version and restore the build type.

Glean.INSTANCE.initialize(aContext, config);
}

Expand Down
2 changes: 1 addition & 1 deletion versions.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def versions = [:]
// GeckoView versions can be found here:
// https://maven.mozilla.org/?prefix=maven2/org/mozilla/geckoview/
versions.gecko_view = "72.0.20191029093803"
versions.android_components = "18.0.0"
versions.android_components = "19.0.0"
versions.mozilla_speech = "1.0.6"
versions.openwnn = "1.3.7"
versions.google_vr = "1.190.0"
Expand Down