This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix crash if onLoadError uri parameter is null #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
reviewed
Mar 19, 2020
Comment on lines
+139
to
+141
| if (uri != null) { | ||
| html = html.replace("%url%", uri); | ||
| } |
There was a problem hiding this comment.
I wonder if it would be better to do:
html = html.replace("%url%", uri != null ? uri : "NULL");
bluemarvin
approved these changes
Mar 19, 2020
keianhzo
approved these changes
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash report:
https://crash-stats.mozilla.com/report/index/edff4a20-a2d4-41a4-9dd5-773d10200319
I reproduced it sending invalid uris in intents