Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repack wheel to exclude 'extra_requires' #828

Merged

Conversation

jschwartzentruber
Copy link
Contributor

fuzzing-decision (used by taskmanager) uses a direct url reference (allowed by PEP 508). But PyPI cannot accept direct url references.

We don't need any of the extras anyways for the wheel (Collector/FTB only).

See pypa/twine#430

fuzzing-decision (used by taskmanager) uses a direct url reference
(allowed by PEP 508). But PyPI cannot accept direct url references.

We don't need any of the extras anyways for the wheel (Collector/FTB only).

See pypa/twine#430
@jschwartzentruber
Copy link
Contributor Author

I'm not sure if there's a better place to put the repack script....

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #828 (1feb303) into master (06edf9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   64.53%   64.53%           
=======================================
  Files         137      137           
  Lines        9780     9780           
  Branches      199      199           
=======================================
  Hits         6312     6312           
  Misses       3448     3448           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06edf9d...1feb303. Read the comment docs.

Copy link
Contributor

@tysmith tysmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jschwartzentruber jschwartzentruber merged commit 6714cec into MozillaSecurity:master Feb 25, 2022
@jschwartzentruber jschwartzentruber deleted the repack-wheel branch February 25, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants