Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the crashesat interestingness test to use argparse, logging and pathlib #199

Merged

Conversation

nth10sd
Copy link
Contributor

@nth10sd nth10sd commented May 31, 2018

This still relies on grabCrashLog so still remaining at this same location for now.

@nth10sd nth10sd self-assigned this May 31, 2018
@nth10sd nth10sd requested a review from jschwartzentruber May 31, 2018 04:54
@codecov-io
Copy link

codecov-io commented May 31, 2018

Codecov Report

Merging #199 into master will increase coverage by 0.09%.
The diff coverage is 36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   44.13%   44.23%   +0.09%     
==========================================
  Files          31       31              
  Lines        2687     2688       +1     
==========================================
+ Hits         1186     1189       +3     
+ Misses       1501     1499       -2
Impacted Files Coverage Δ
src/funfuzz/util/crashesat.py 34.28% <36%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a7f75...1883710. Read the comment docs.

Copy link
Collaborator

@jschwartzentruber jschwartzentruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nth10sd nth10sd merged commit 35b5e09 into MozillaSecurity:master May 31, 2018
@nth10sd nth10sd deleted the switch-crashesat-to-argparse branch May 31, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants