This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
fix(glean): rename events to use kebab case #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtfluckey
commented
Oct 19, 2023
| @@ -52,7 +52,7 @@ function previewAvatar() { | |||
| } | |||
|
|
|||
| async function toggleNotifications() { | |||
| const dataGlean = relationship?.notifying ? 'profile.notify_stop' : 'profile.notify_start' | |||
| const dataGlean = relationship?.notifying ? 'profile.notify.stop' : 'profile.notify.start' | |||
There was a problem hiding this comment.
These events were renamed to include the . separation between notify and the action (start or stop)
wtfluckey
commented
Oct 19, 2023
| @@ -23,7 +23,7 @@ const { client } = $(useMasto()) | |||
| const useStarFavoriteIcon = usePreferences('useStarFavoriteIcon') | |||
| const { share, isSupported: isShareSupported } = useShare() | |||
|
|
|||
| function recordEngagement(dataGlean) { | |||
| function recordEngagement(dataGlean: string) { | |||
There was a problem hiding this comment.
Added a type here to make vscode happy
There was a problem hiding this comment.
Hmm my vscode doesn't get sad over this. Do you have any idea what the difference is in our IDEs?
There was a problem hiding this comment.
Not sure. I thought maybe I had a typescript extension on in vscode, but apparently I don't. Do you have one?
There was a problem hiding this comment.
I disabled some extension with the word TypeScript in it that I couldn't find in the marketplace, and then I updated my IDE. Now I'm getting the error. Not sure which of the two was the culprit though
4 tasks
jpezninjo
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #67 I noticed that we had a mix of cases when it came to naming our engagement events, so I reached out to the data analytics team to see if they had a preference. They decided on
kebab-case, so this PR simply updates the existing engagement events, plus those in #67, to be consistent. Two other small changes called out in comments.This PR is to be merged into #67.