fix(settings): change elk to moz social in notifications settings [MOSOWEB-89] #84
Conversation
| @@ -524,10 +524,10 @@ | |||
| "unsupported": "Your browser does not support push notifications.", | |||
| "warning": { | |||
| "enable_close": "Close", | |||
| "enable_description": "To receive notifications when Elk is not open, enable push notifications. You can control precisely what types of interactions generate push notifications via the \"@:settings.notifications.show_btn{'\"'} button above once enabled.", | |||
| "enable_description_desktop": "To receive notifications when Elk is not open, enable push notifications. You can control precisely what types of interactions generate push notifications in \"Settings > Notifications > Push notifications settings\" once enabled.", | |||
| "enable_description": "To receive notifications when Mozilla.social is not open, enable push notifications. You can control precisely what types of interactions generate push notifications via the \"@:settings.notifications.show_btn{'\"'} button above once enabled.", | |||
There was a problem hiding this comment.
The 3 translation entries are for the 3 different versions of this UI, based on a prop called closeableHeader and a css check for xl
|
@wtfluckey good call. Pushed up |
| @@ -479,10 +479,10 @@ | |||
| "unsupported": "Ihr Browser unterstützt keine Push-Benachrichtigungen.", | |||
| "warning": { | |||
| "enable_close": "Schließen", | |||
| "enable_description": "Um Benachrichtigungen zu erhalten, wenn Elk nicht geöffnet ist, aktiviere Push-Benachrichtigungen. \nDu kannst genau steuern, welche Arten von Interaktionen Push-Benachrichtigungen generieren, indem du die Schaltfläche \"@:settings.notifications.show_btn{'\"'} oben aktivierest, sobald sie aktiviert ist.", | |||
| "enable_description_desktop": "Um Benachrichtigungen zu erhalten, wenn Elk nicht geöffnet ist, aktiviere Push-Benachrichtigungen. \nDu kannst unter „Einstellungen > Benachrichtigungen > Einstellungen für Push-Benachrichtigungen“ genau steuern, welche Arten von Interaktionen Push-Benachrichtigungen generieren, sobald diese aktiviert sind.", | |||
| "enable_description": "Um Benachrichtigungen zu erhalten, wenn Mozilla.social nicht geöffnet ist, aktiviere Push-Benachrichtigungen. \nDu kannst genau steuern, welche Arten von Interaktionen Push-Benachrichtigungen generieren, indem du die Schaltfläche \"@:settings.notifications.show_btn{'\"'} oben aktivierest, sobald sie aktiviert ist.", | |||
There was a problem hiding this comment.
It was already wrong in the previous version, but since you're already on it: "aktivierest" should be "aktivierst". I am not sure if that's the best word, and it's also not what the English original says. Additionally, "aktivierst" would be repeated twice in quick succession. This doesn't sound good and even makes the sentence a bit confusing.
Suggestion for enable_description: "Um Benachrichtigungen zu erhalten, wenn Mozilla.social nicht geöffnet ist, aktiviere Push-Benachrichtigungen. \nÜber die Schaltfläche "@:settings.notifications.show_btn{'"'} oben kannst genau steuern, welche Arten von Interaktionen Push-Benachrichtigungen generieren, sobald diese aktiviert ist."
This would be closer to the English translation and less confusing.
Goal
Replace "Elk" text from Push Notifications settings with "Mozilla.social" MOSOWEB-89
Image of the affected spot in local:
How to Test this
I did some stuff in
components/notification/NotificationPreferences.client.vueandpages/settings/notifications/push-notifications.vueto force my way into the route 🤷Something about
pwaEnableddisallows this page in local