fix(metrics.yaml): include new data_taxonomy & data_reviews info #86

wtfluckey · 2023-11-15T20:44:14Z

Update our metrics.yaml file to match the shared metrics.yaml file to include the new data_taxonomy and data_reviews information

Requesting review from Kirill as well since I made changes to the metrics.yaml file and we are trying to keep it as consistent as possible across clients and want to make sure that the changes I've made here don't violate our legal requirements.

Completed:

Add bugs info to all metrics
Add data_reviews info to all metrics
Add data_taxonomy for all metrics
Included fxa_account_id metric per Kirill's request

wtfluckey · 2023-11-15T20:54:14Z

telemetry/metrics.yaml

@kirill-demtchouk I copied over your metrics.yaml file and then made the following changes in order for it to work on web:

removed fxa_account_id, adjust_device_id and backend category as these are not relevant to web

added bugs: TBD back to each metric as the build:glean script fails without it

moved baseline out of send_in_pings and into no_lint

the build:glean script fails if we keep as is

alternatively, web could remove baseline altogether

added back lifetime: application to the non-event metrics

this is what makes it so that those identifiers get sent with every ping and I have yet to figure out a different way to do this

Can we keep the fxa_account_id, even if we're not using it at the moment?

What does no_lint do? I can't find any mention of it in the Glean docs 🙃

I think the other changes are 👌 , thank you for making them!

Actually, can we set the bugs field to a value of https://mozilla-hub.atlassian.net/browse/MSDO-49?

Thank you for the feedback @kirill-demtchouk! I made some changes:

added https://mozilla-hub.atlassian.net/browse/MSDO-49 as the bugs field to all metrics

added back the fxa_account_id

fixed a couple tiny typos (I'll call them out so you can make the changes in your metrics.yaml file as well)

The no_lint line suppresses the warning we get when running the build or lint commands. If we leave baseline as-is, we get this error:

ERROR: BASELINE_PING: identifiers.fxa_account_id: The baseline ping is Glean-internal. Remove 'baseline' from the send_in_pings array.

If you'd rather we just remove the baseline instead of classifying it as no_lint, that would be fine with me, just let me know!

@wtfluckey Let's remove the baseline ping since it's not relevant to the Glean js SDK. I will make those typo changes on my side. Thank you for catching them!

I'm feeling sick and will likely be offline this afternoon (and I'm out next week on PTO). Going to approve this PR to unblock you, it's not material for me to review the baseline ping change alone.

This looks good n' compliant to me 😄 Thank you for hashing out the last edits!

Thank you for all your help @kirill-demtchouk!! Also, I hope you feel better and have an excellent thanksgiving!

Thanks, Aly! One last thing: can we changed the "app_id" defined in the code to "moso-mastodon-web"? It's currently set to "mozilla-social-web".

Done as part of #89

jpezninjo · 2023-11-15T21:35:04Z

telemetry/generated/web.ts

 import EventMetricType from "@mozilla/glean/private/metrics/event";
+import StringMetricType from "@mozilla/glean/private/metrics/string";


woohoo I've been ignoring this particular generated change in my local

jpezninjo

Not sure about metrics.yaml with the open comment, but I understand that the changes to that file in this PR are part of one entire file copy. Everything else looks good to me.

wtfluckey · 2023-11-17T18:08:26Z

telemetry/metrics.yaml

        type: string
      ui_additional_detail: &ui_additional_detail
        description: >
-          An optional string to record further informatin about the UI
+          An optional string to record further information about the UI


@kirill-demtchouk - fixed a typo here

wtfluckey · 2023-11-17T18:08:42Z

telemetry/metrics.yaml

@@ -170,13 +276,19 @@ web:
    description: >
      The full URL of the previous web page from which a link was followed
      in order to trigger the page view.
-      Comes from the `referer` field of the HTTP header.
+      Comes from the `referrer` field of the HTTP header.


@kirill-demtchouk - one other typo here

kirill-demtchouk · 2023-11-28T15:08:07Z

@wtfluckey should we start sending events once this PR is merged?

wtfluckey requested a review from a team as a code owner November 15, 2023 20:44

wtfluckey commented Nov 15, 2023

View reviewed changes

wtfluckey requested a review from kirill-demtchouk November 15, 2023 20:54

jpezninjo reviewed Nov 15, 2023

View reviewed changes

jpezninjo approved these changes Nov 15, 2023

View reviewed changes

wtfluckey force-pushed the feat/glean-update-metrics.yaml branch from 63a39e8 to eed66aa Compare November 17, 2023 18:01

wtfluckey commented Nov 17, 2023

View reviewed changes

kirill-demtchouk approved these changes Nov 17, 2023

View reviewed changes

wtfluckey added 6 commits November 27, 2023 14:24

fix(metrics.yaml): include new data_taxonomy & data_reviews info

0af98fa

fix(metrics.yaml): add bugs field

6a6c08a

fix(metrics.yaml): add back fxa_account_id

541cbf6

fix(metrics): remove no_lint: baseline

3398a17

fix(readme): update telemetry readme

0724257

fix(identifiers): update fxaAccountId

3240025

wtfluckey force-pushed the feat/glean-update-metrics.yaml branch from eed66aa to 541cbf6 Compare November 27, 2023 20:17

wtfluckey merged commit 49f2cef into main Nov 27, 2023
5 checks passed

wtfluckey deleted the feat/glean-update-metrics.yaml branch November 27, 2023 21:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(metrics.yaml): include new data_taxonomy & data_reviews info #86

fix(metrics.yaml): include new data_taxonomy & data_reviews info #86

wtfluckey commented Nov 15, 2023 •

edited

Loading

wtfluckey Nov 15, 2023

kirill-demtchouk Nov 15, 2023 •

edited

Loading

kirill-demtchouk Nov 15, 2023

wtfluckey Nov 17, 2023

kirill-demtchouk Nov 17, 2023

kirill-demtchouk Nov 17, 2023

wtfluckey Nov 17, 2023 •

edited

Loading

kirill-demtchouk Nov 20, 2023

wtfluckey Nov 27, 2023

jpezninjo Nov 15, 2023

jpezninjo left a comment

wtfluckey Nov 17, 2023

wtfluckey Nov 17, 2023

kirill-demtchouk commented Nov 28, 2023

		import EventMetricType from "@mozilla/glean/private/metrics/event";
		import StringMetricType from "@mozilla/glean/private/metrics/string";

fix(metrics.yaml): include new data_taxonomy & data_reviews info #86

fix(metrics.yaml): include new data_taxonomy & data_reviews info #86

Conversation

wtfluckey commented Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

kirill-demtchouk Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wtfluckey Nov 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpezninjo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kirill-demtchouk commented Nov 28, 2023

wtfluckey commented Nov 15, 2023 •

edited

Loading

kirill-demtchouk Nov 15, 2023 •

edited

Loading

wtfluckey Nov 17, 2023 •

edited

Loading