Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add terms of service #18

Merged
merged 1 commit into from
May 1, 2023
Merged

add terms of service #18

merged 1 commit into from
May 1, 2023

Conversation

toufali
Copy link
Collaborator

@toufali toufali commented May 1, 2023

No description provided.

@toufali toufali merged commit 67c0cff into main May 1, 2023
@toufali toufali deleted the add-terms-of-service branch May 1, 2023 22:58
@rhelmer rhelmer self-requested a review May 2, 2023 00:31
Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

multiColumn: PropTypes.bool,
};

state = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this unused state object. Same with intl propType above. They're holdovers from the Privacy Policy page that this page mimics, but we are hard-coding the date and content.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I waffled on keeping vs leaving. I down to remove, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants