chore(sync fork): [SOCPLAT-34] Merge Mastodon v4.2.3 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rforming a custom action (mastodon#27442)
…for remote accounts (mastodon#27459)
…rted into timelines (mastodon#27653)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nina-py
commented
Dec 5, 2023
Comment on lines
3
to
10
| ready(() => { | ||
| const form = document.querySelector('#sso_form') | ||
| form.insertAdjacentHTML('beforeend', '<h4>Redirecting...</h4>') | ||
| form.elements['commit'].style.setProperty('visibility', 'hidden') | ||
| form.elements['intent'].value = localStorage.getItem('mozsoc.auth_intent') | ||
| form.elements.commit.style.setProperty('visibility', 'hidden') | ||
| form.elements.intent.value = localStorage.getItem('mozsoc.auth_intent') | ||
| localStorage.removeItem('mozsoc.auth_intent'); | ||
| form.submit(); | ||
| }); |
There was a problem hiding this comment.
The linter required a change to the dot notation here
There was a problem hiding this comment.
Thanks for calling this out – should be fine for this case 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new PR to follow a rapid release of another patch version.
Note: no merge conflicts whatsoever this time. This release fixes a number of bugs - mostly frontend; Ruby updates don't conflict with any of our changes.
A notable difference is in the number of checks: they're up from 60 per pull request to 71. Linter checks in particular have been split into several, e.g. CSS/JavaScript/Ruby/YML are all being checked separately which speeds up the waiting time. Some of these linting checks were failing on our code changes - all fixed now.
JIRA reference: https://mozilla-hub.atlassian.net/browse/SOCPLAT-34