Delete attachment async when the admin status API is triggered #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toufali
approved these changes
Feb 22, 2024
aaga
suggested changes
Feb 22, 2024
| @@ -28,7 +28,7 @@ def destroy | |||
| if @status.with_media? | |||
| # Immediately remove public copy of media instead of waiting for | |||
| # the vacuum_orphaned_records job to take care of it later on | |||
| Admin::MediaAttachmentDeletionWorker.perform_inline(@status.media_attachments) | |||
| Admin::MediaAttachmentDeletionWorker.perform_async(@status.media_attachments.map(&:id)) | |||
There was a problem hiding this comment.
same change needs to be made in status_batch_action.rb
btw do we know how soon is the expected execution of a perform_async task? It should not be later than a couple minutes (if e.g. we need to take down a particularly egregious piece of media)
There was a problem hiding this comment.
Follow up for the fix!
About the timing, it's just an async call. Locally it's triggered after less than 1 second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.