Delete S3 media individually instead of in batches #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakulf
approved these changes
Mar 7, 2024
toufali
reviewed
Mar 7, 2024
toufali
approved these changes
Mar 7, 2024
| # since GCP XML API doesn't support batch delete | ||
| logger.debug { "Deleting #{keys.size} objects" } | ||
| keys.each do |key| | ||
| bucket.object(key).delete |
There was a problem hiding this comment.
interesting that your non-batch version is less lines and less complex than the original batch version that needs to be sliced anyway! 🚀
There was a problem hiding this comment.
haha! the batching makes a difference on the S3 side - putting it into slices of 1000 means all those 1000 media get deleted simultaneously, rather than O(n) with the non-batch way.
but it all gets deleted eventually so it shouldn't be an issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.