This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Preview card #216
Merged
Preview card #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JohnOberhauser
commented
Oct 26, 2023
•
JohnOberhauser
commented
- Adding a link preview card to statuses
- Had to update our models and mappings
- Added the PreviewCard ui
- Reducing the length of links based on the html span tags
JohnOberhauser
requested review from
a team,
devotaaabel and
timc-mozilla
and removed request for
a team
devotaaabel
approved these changes
Oct 26, 2023
| embedUrl = embedUrl, | ||
| blurHash = blurHash | ||
| ) | ||
| else -> throw Exception("type value is incorrect") |
There was a problem hiding this comment.
I like using error("message") for these types of things which defaults to an IllegalStateException which I think is appropriate here (also it would mean we don't have to supress the detekt rule)
| import kotlin.test.assertEquals | ||
|
|
||
| @Suppress("MaxLineLength") | ||
| class ReduceHtmlLinksTest { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.