This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Edit profile part 2 - Avatar and Header #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JohnOberhauser
commented
Oct 31, 2023
JohnOberhauser
commented
- Adding the ability to upload a new avatar and header
- Adding loading and error states when saving
- Holding off on any more navigation stuff until [MOSOAND-207] Added EventRelay to for high-level app events like navigation and snackbars #224 is merged
- So the app doesn't automatically navigate back after saving is complete
JohnOberhauser
requested review from
a team,
devotaaabel and
timc-mozilla
and removed request for
a team
devotaaabel
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.