Follow count fix #233
Follow count fix #233
Conversation
JohnOberhauser
commented
Nov 2, 2023
JohnOberhauser
commented
- Making the database update your following count when you follow or unfollow someone
- Adding unit tests for these methods
- Creating a base test for repository testing
JohnOberhauser
requested review from
a team,
devotaaabel and
timc-mozilla
and removed request for
a team
| @@ -105,23 +106,44 @@ class AccountRepository internal constructor( | |||
| suspend fun getAccountFavourites(): List<Status> = | |||
| accountApi.getAccountFavourites().map { it.toExternalModel() } | |||
|
|
|||
| suspend fun followAccount(accountId: String) { | |||
| suspend fun followAccount( | |||
There was a problem hiding this comment.
Would you be open to putting this logic in a use case (or at least a separate function)? My thinking is that we'd only want this to happen if a user is looking at some UI with the follow count. Otherwise it's kind of wasted cycles
There was a problem hiding this comment.
I think this logic should run even if you're not looking at the UI. You might navigate back to a screen that is affected by this and expect the UI to be updated. I'm worried about someone not calling this function when following an account, and creating a bug in the process.
I actually have a very related topic added to the TIP agenda. Is it okay to merge this in as-is for now? I might end up refactoring a lot of stuff into use-cases depending on the outcome of that conversation.
