This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
fixing timelines #236
Merged
fixing timelines #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnOberhauser
requested review from
a team,
devotaaabel and
timc-mozilla
and removed request for
a team
devotaaabel
approved these changes
Nov 3, 2023
| ).map { it.toExternalModel() } | ||
| ) | ||
|
|
||
| if (!response.isSuccessful) { |
There was a problem hiding this comment.
I think ideally we'd return a type that can either be a success or error (obviously we're not doing that anywhere but I think that's the ideal state). Just something to aspire towards...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, I started getting 19 statuses back from the API during home timeline paging, even though I'm requesting 20. Our current logic is that if the response count != the request page size, that means we are done paging. We should instead be checking if there is a
nextlink header.