This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Content warnings #282
Merged
Content warnings #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JohnOberhauser
commented
Nov 15, 2023
JohnOberhauser
commented
- Updating content warning UI in new post screen
- Adding content warnings to post cards
JohnOberhauser
requested review from
a team,
devotaaabel and
timc-mozilla
and removed request for
a team
devotaaabel
approved these changes
Nov 16, 2023
| @@ -131,6 +131,9 @@ object MoSoIcons { | |||
| @Composable | |||
| fun lock() = painterResource(id = R.drawable.lock) | |||
|
|
|||
| @Composable | |||
There was a problem hiding this comment.
This isn't a huge deal but I've been trying to keep these alphabetized (Though it wouldn't be hard to convince me that it's not necessary)
| ) { | ||
| Column { | ||
| val hasContentWarning by remember(contentWarningText) { | ||
| mutableStateOf(contentWarningText.isNotBlank()) |
There was a problem hiding this comment.
I think you want to use derivedStateOf instead of mutableStateOf
| mutableStateOf(contentWarningText.isNotBlank()) | ||
| } | ||
| var isShowing by remember(hasContentWarning) { | ||
| mutableStateOf(!hasContentWarning) |
There was a problem hiding this comment.
This one has to be mutable since I'm changing the value when the user clicks the content warning
added 2 commits
November 15, 2023 18:47
…into contentWarnings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.