This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Blocks and mutes list part 2 - Created and populated blocks list screen with api result #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…locks api to blocks list. Updated QuickAccountView with a button slot and to conform to guidelines
devotaaabel
requested review from
a team,
JohnOberhauser and
timc-mozilla
and removed request for
a team
devotaaabel
force-pushed
the
blocked-users-screen
branch
from
7705427
to
1eb0367
Compare
|
|
||
| // TODO@DA error handling and unblock | ||
| fun onBlockButtonClicked(accountId: String) { | ||
| viewModelScope.launch(ioDispatcher) { accountRepository.muteAccount(accountId) } |
There was a problem hiding this comment.
You should use the BlockAccount use case to ensure the database is updated properly
| fun onMuteButtonClicked( | ||
| accountId: String, | ||
| ) { | ||
| viewModelScope.launch(ioDispatcher) { accountRepository.muteAccount(accountId) } |
There was a problem hiding this comment.
Same here, but with MuteAccount
JohnOberhauser
approved these changes
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been reading the API guidelines for compose, and I've tried to implement a few suggestions in this PR:
SmallTextLabel,LargeTextTitle, etc.) instead of manually always needing to pass in style to emulate "building blocks" described in docsQuickAccountViewwith a button slot (and other guidelines)