This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Splash + Scaffold #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devotaaabel
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Looks good! I would like for us to find a pattern for accessing/building the route strings in a scalable way that works with arguments, maybe using a sealed class or interface. But we can figure it out along the way
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splash screen
I didn't create a separate screen for the splash screen. Just made the login screen empty while we are still loading the
isSignedInflow.Scaffold
Added a scaffold with a bottom nav
Followed a similar pattern to nowinandroid
#28
#26