Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Followers part 4 #298

Merged
merged 6 commits into from
Nov 19, 2023
Merged

Followers part 4 #298

merged 6 commits into from
Nov 19, 2023

Conversation

JohnOberhauser
Copy link
Member

  • Making MoSoToggleButton take the toggle state as a parameter because I need this to be reactive
    • Creating MoSoAutomaticToggleButton that does what MoSoToggleButton used to do
  • Updating AccountQuickView to take a bio and fixing some ellipsis / spacing issues
  • Creating a new module for FollowAccount composable that uses AccountQuickView
  • Hooking everything up in the follow screen to use the new ui

@JohnOberhauser JohnOberhauser requested review from a team, devotaaabel and timc-mozilla and removed request for a team November 19, 2023 00:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment- I've been deleting these when adding new modules... I'm not sure there's a point of including them if we're not adding rules (or maybe we should be adding rules in which case I'll add them back, but I'm just not really sure what we're supposed to do here)

@JohnOberhauser JohnOberhauser enabled auto-merge (squash) November 19, 2023 17:03
@JohnOberhauser JohnOberhauser merged commit d7e2e82 into main Nov 19, 2023
3 checks passed
@JohnOberhauser JohnOberhauser deleted the followers4 branch November 19, 2023 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants