This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Follow hashtag button #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JohnOberhauser
commented
Jan 3, 2024
JohnOberhauser
commented
- Adding a follow button to the hashtag screen
- Because we need to get the follow state from network, I'm also adding loading and error states to the hashtag screen
JohnOberhauser
requested review from
a team,
devotaaabel and
timc-mozilla
and removed request for
a team
added 2 commits
January 3, 2024 17:45
devotaaabel
approved these changes
Jan 5, 2024
Comment on lines
+214
to
+218
| single { | ||
| GetHashTag( | ||
| hashtagRepository = get(), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Suggested change
| single { | |
| GetHashTag( | |
| hashtagRepository = get(), | |
| ) | |
| } | |
| singleOf(::GetHashTag) |
There was a problem hiding this comment.
GetHashTag has another parameter for the coroutine dispatcher with a default value, so we have to use the normal constructor pattern
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.