Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions to ZigbeeNet #160

Merged
merged 12 commits into from
Aug 23, 2021

Conversation

JanneMattila
Copy link
Contributor

Here's first take on the GitHub Actions implementation to ZigbeeNet. In case process does not make sense then please provide feedback and I'll change it.

Maybe notable difference would be using tag name from GitHub Release for versioning of the NuGet packages. And those would share the versioning between packages. That can be of course skipped and use only versioning from the .csproj but of course you would have to increment them manually always.

This setup has been put into here for reference for easier review and validation.

@Mr-Markus Mr-Markus merged commit df03e78 into Mr-Markus:develop Aug 23, 2021
@Mr-Markus
Copy link
Owner

Hi @JanneMattila

thanks for your PR. I merge it into develop and master, removed appvayor and added $NUGET_API_KEY variable. CI is working, but CD not.
Could you please check what's wrong in https://github.com/Mr-Markus/ZigbeeNet/actions/runs/1158384590 please?
I don't understand how it's working, yet but hope I will do it if it's running

@JanneMattila
Copy link
Contributor Author

Sure. Let me check and update you.

@JanneMattila
Copy link
Contributor Author

It's expecting release version tag to start with v e.g., v1.5.0 and strips out that start character. Could you try with that? Error messages are visible under Actions menu and then CD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants