Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support log appender/handler configuration #22

Open
codeboten opened this issue Dec 6, 2022 · 4 comments
Open

Support log appender/handler configuration #22

codeboten opened this issue Dec 6, 2022 · 4 comments

Comments

@codeboten
Copy link
Collaborator

Follow up from #20, users must have a way to specify hooking up log appenders/handlers to the logging provider.

The wiring up of appenders to the SDK seems more like an instrumentation concern than an SDK concern. I suggest we include that under the instrumentation section. I.e. something like:

sdk:
  ...
instrumentation:
  log_appenders:
    - name: log4j
    - name: logback

Originally posted by @jack-berg in #20 (comment)

@codeboten
Copy link
Collaborator Author

We may want to add this under a language-specific section:

sdk:
  ...
instrumentation:
  ...
java:
  log_appenders:
    - name: log4j
    - name: logback
python:
  log_handlers:
    - name: logging

@svrnm
Copy link

svrnm commented Dec 12, 2022

looks like those appenders are language specific, so the 2. would match that, although I am wondering if java, python etc are top level elements or if they should be sub-elements of sdk/instrumentation?

@codeboten
Copy link
Collaborator Author

there are some language specific options that apply to things outside of instrumentations, maybe a language section would work? For now we could always say they are top level elements and change it later

@svrnm
Copy link

svrnm commented Dec 13, 2022

there are some language specific options that apply to things outside of instrumentations, maybe a language section would work? For now we could always say they are top level elements and change it later

I would prefer a language or languageSpecific or similar parent element, because the list of languages is technically not limited and that makes me worry that there is eventually an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants