Add logger_provider exporter and log_record_processors #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
srikanthccv
reviewed
Dec 5, 2022
| # Environment variable: OTEL_EXPORTER_OTLP_TIMEOUT, OTEL_EXPORTER_OTLP_LOGS_TIMEOUT | ||
| timeout: 10000 | ||
| # List of log record processors. Each log record processor has a name and args used to configure it. | ||
| log_record_processors: |
There was a problem hiding this comment.
I know the "appender"/handler is language-specific, but I think it is essential to the logging SDK configuration. Should this minimal config define some mechanism for it?
There was a problem hiding this comment.
Good question.
The wiring up of appenders to the SDK seems more like an instrumentation concern than an SDK concern. I suggest we include that under the instrumentation section. I.e. something like:
sdk:
...
instrumentation:
log_appenders:
- name: log4j
- name: logback
There was a problem hiding this comment.
Created a separate issue for configuring handlers, feel free to resolve that issue in this PR or separately.
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
codeboten
approved these changes
Dec 6, 2022
srikanthccv
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5.