add version to config file #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a version value to the configuration file. Fixes #11 Signed-off-by: Alex Boten <aboten@lightstep.com>
jack-berg
approved these changes
Nov 21, 2022
pellared
reviewed
Nov 22, 2022
| @@ -0,0 +1,2 @@ | |||
| # include version specification in configuration files to help with parsing and schema evolution. | |||
| version: 0.0.1 | |||
There was a problem hiding this comment.
What would be the use case to bump the "patch number"?
I am used to have "patch" when versioning the config files. Usually it is only "major" or "major.minor" depending on how strict is the parser.
There was a problem hiding this comment.
Also I think it should be named scheme-version. version suggests that this is the version of the config.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a version value to the configuration file. Fixes #11
Signed-off-by: Alex Boten aboten@lightstep.com