python configuration prototype #44

codeboten · 2023-02-10T20:11:58Z

Here's the start of the python prototype. Specifically here, I wanted to test out the ergonomics of using the dictionary object parsed from the config file. I've updated a couple of things in the schema/config file as a result which I'm not opposed to changing back but here's the list of changes:

changed propagators to an array of strings instead of objects. propagators are currently identified by a string in the spec. This means in theory users would be limited in what they can configure in a propagator, but that's the state of the world today.
renamed *_provider to the signal name instead. i think this makes understand the configuration a bit more ergonomic since for example we're configuring exporters for the signal, and then applying them to a specific processor. the user may not need to know this is configuring the provider specifically.
changed processors to the same format as the exporter with type/identifier naming

The code as is supports configuring a console exporter, and turning on/off the SDK. I will continue adding more interpretation of the configuration in the future. The only interface users would interact with is shown in prototype.py as the following:

    otel.configure(otel.parse_and_validate_from_config_file(sys.argv[1], sys.argv[2]))

ocelotl · 2023-02-13T18:48:50Z

prototypes/python/otel.py

@@ -0,0 +1,119 @@
+
+import importlib


Nit, use from x import y

martinkuba · 2023-02-13T23:04:41Z

Question about the processor names - what is the reason that the name includes the exporter name after the slash? I can see it as a more descriptive name, but the type of the processor will have to be parsed from the name.

codeboten · 2023-02-13T23:24:17Z

Question about the processor names - what is the reason that the name includes the exporter name after the slash? I can see it as a more descriptive name, but the type of the processor will have to be parsed from the name.

It's probably not necessary, since the name is really identifying the type of processor this is and not used as a unique identifier anywhere else. I suppose it could make returning an error when configuring a specific processor a bit more easy to identify, but it's probably not needed at this time

Signed-off-by: Alex Boten <aboten@lightstep.com>

Updated the list of propagators to an array of strings. Renamed *_provider to the name of the signal instead. This makes searching the parsed configuration a bit cleaner, since exporters are configured per signal, and not necessarily per provider (at least conceptually i found it easier to grok). Signed-off-by: Alex Boten <aboten@lightstep.com>

Signed-off-by: Alex Boten <aboten@lightstep.com>

ocelotl · 2023-02-23T18:58:10Z

prototypes/python/otel.py

+
+import logging
+from typing import List, Sequence, Tuple
+from pkg_resources import iter_entry_points


pkg_resources has been deprecated (see this, and also this).

Ah good to know. It's probably ok for the prototype but wouldn't want to ship this code :D

ocelotl · 2023-02-23T19:01:31Z

prototypes/python/otel.py

+    def _resource(self):
+        # resource detection
+        # attributes
+        from opentelemetry.sdk.resources import Resource


Why import here?

not necessary to have the import in the method, that was just me being lazy

ocelotl

Just some comments

codeboten · 2024-01-12T16:12:10Z

Closing in favour of open-telemetry/opentelemetry-configuration#54

ocelotl reviewed Feb 13, 2023

View reviewed changes

prototypes/python/otel.py Outdated

@@ -0,0 +1,119 @@

import importlib

Copy link

ocelotl Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, use from x import y

codeboten force-pushed the codeboten/py-prototype branch from c67d0fe to e45b943 Compare February 15, 2023 04:21

Alex Boten added 7 commits February 21, 2023 14:39

python config prototype

f6054e5

Signed-off-by: Alex Boten <aboten@lightstep.com>

more work to get prototype working

d7e9916

Signed-off-by: Alex Boten <aboten@lightstep.com>

change object to array

c3006c9

use entry points where possible

a0f95ed

Signed-off-by: Alex Boten <aboten@lightstep.com>

update prototype to test out otlp, added insecure field

e123d14

Signed-off-by: Alex Boten <aboten@lightstep.com>

add meter provider configuration

bacb1d4

Signed-off-by: Alex Boten <aboten@lightstep.com>

codeboten force-pushed the codeboten/py-prototype branch from 159b1b5 to bacb1d4 Compare February 21, 2023 23:38

ocelotl reviewed Feb 23, 2023

View reviewed changes

codeboten mentioned this pull request Feb 28, 2023

Configuration proposal open-telemetry/oteps#225

Merged

codeboten mentioned this pull request Sep 18, 2023

Python configuration working group prototype open-telemetry/opentelemetry-python#3443

Open

codeboten closed this Jan 12, 2024

codeboten deleted the codeboten/py-prototype branch January 12, 2024 16:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python configuration prototype #44

python configuration prototype #44

codeboten commented Feb 10, 2023

ocelotl Feb 13, 2023

martinkuba commented Feb 13, 2023

codeboten commented Feb 13, 2023

ocelotl Feb 23, 2023

codeboten Feb 23, 2023

ocelotl Feb 23, 2023

codeboten Feb 23, 2023 •

edited

Loading

ocelotl left a comment

codeboten commented Jan 12, 2024

python configuration prototype #44

python configuration prototype #44

Conversation

codeboten commented Feb 10, 2023

ocelotl Feb 13, 2023

Choose a reason for hiding this comment

martinkuba commented Feb 13, 2023

codeboten commented Feb 13, 2023

ocelotl Feb 23, 2023

Choose a reason for hiding this comment

codeboten Feb 23, 2023

Choose a reason for hiding this comment

ocelotl Feb 23, 2023

Choose a reason for hiding this comment

codeboten Feb 23, 2023 • edited Loading

Choose a reason for hiding this comment

ocelotl left a comment

Choose a reason for hiding this comment

codeboten commented Jan 12, 2024

codeboten Feb 23, 2023 •

edited

Loading