Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export some types directly #15

Merged
merged 3 commits into from
Mar 13, 2022
Merged

export some types directly #15

merged 3 commits into from
Mar 13, 2022

Conversation

B-Reif
Copy link
Contributor

@B-Reif B-Reif commented Mar 12, 2022 •
edited
Loading

Per #14 this PR hides some modules and exports their types directly.

  • Hides modules components, plugin, and prototype.
  • Exports types ProtoComponent, ProtoPlugin, Prototype, and Prototypical directly, and in the prelude.
  • Exports the deserialize_templates_list function directly, but not the in the prelude.
  • Bumps the version number for the possible breaking change.

MrGVSV
MrGVSV requested changes Mar 12, 2022
View reviewed changes
Copy link
Owner

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few comments.

Overall, though, I think this is a much better option for us and will reduce the chance of accidentally exporting internal types/functions to the public API.

Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@MrGVSV MrGVSV merged commit d8196e1 into MrGVSV:main Mar 13, 2022
@B-Reif B-Reif deleted the refactor-types branch March 13, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B-Reif @MrGVSV