Implement hot reloading for prototypes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
approved these changes
Oct 3, 2022
| @@ -18,6 +18,8 @@ typetag = "0.2" | |||
| serde_yaml = "0.9" | |||
| dyn-clone = "1.0" | |||
| indexmap = "1.9" | |||
| crossbeam-channel = { version = "0.5", optional = true } | |||
| notify = { version = "=5.0.0-pre.15", optional = true } | |||
There was a problem hiding this comment.
Does this specifically need to be =5.0.0-pre.15? Can it work with just 5.0.0 (which is what Bevy's using)?
There was a problem hiding this comment.
I used =5.0.0-pre.15 because that's what Bevy 0.8(.1) uses.
|
Merging now. I'll put together a release soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements hot-reloading if the feature
hot_reloadingis enabled. Note that hot reloading only works for the first path specified inProtoDataOptions.The core implementation was copied from
bevy_asset, with minor details changed to fit.This PR will be obsoleted by #18, as Bevy's native asset hot reloading can be used instead.