Add PrototypesMut::load_folder #36
Conversation
| let handles: Vec<_> = handles.iter().map(|handle| handle.clone().typed::<T>()).collect(); | ||
|
|
||
| handles.iter().for_each(|handle| { | ||
| let path = self.asset_server.get_handle_path(handle).unwrap().path().to_str().unwrap().to_string(); |
There was a problem hiding this comment.
This is a bit gross, we should probably handle the error cases instead of calling unwrap.
Perhaps I should add PrototypesError?
There was a problem hiding this comment.
Theoretically this should always return a path, right? If so, I think we can go ahead and just unwrap it (maybe with an .expect() instead).
Same for the call to to_str (which we could replace with to_str_lossy but that could break the mapping).
There was a problem hiding this comment.
I added some errors for this, let me know what you think
| let handles: Vec<_> = handles.iter().map(|handle| handle.clone().typed::<T>()).collect(); | ||
|
|
||
| handles.iter().for_each(|handle| { | ||
| let path = self.asset_server.get_handle_path(handle).unwrap().path().to_str().unwrap().to_string(); |
There was a problem hiding this comment.
Theoretically this should always return a path, right? If so, I think we can go ahead and just unwrap it (maybe with an .expect() instead).
Same for the call to to_str (which we could replace with to_str_lossy but that could break the mapping).
bevy_proto_backend/src/path/error.rs
Outdated
| /// The path cannot be converted to a string. | ||
| #[error("cannot convert path to a string")] | ||
| ConversionError |
There was a problem hiding this comment.
Nit: I wonder if this should give more info regarding why it failed. Like maybe it should be called NotUtf8 or maybe the error message should indicate that the path was not valid UTF-8.
There was a problem hiding this comment.
I think NotUtf8 works
| .path() | ||
| .to_str() | ||
| .ok_or(PathError::ConversionError)? | ||
| .to_string(); |
There was a problem hiding this comment.
Actually, what if we took in P: Into<PathBuf> and then stored the PathBuf in ProtoStorage instead of Cow<'static, str>?
This way we don't need to worry about conversions (we can remove the ConversionError) and it's a little more clear we're looking for paths to files and not just their ID or something.
Add
PrototypesMut::load_folderso that it mirrorsAssetServer::load_folder, with the exception that the returned handles are typed.