Fix unexpected activity finish on configuration change #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finishing an activity does not make much sense if it's in the process of recreation or has already been finished.
MrHadiSatrio
force-pushed
the
fix/config_change
branch
from
f644fee to
5163575
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
ActivityCompletionEventSinknow checks forisFinishingandisChangingConfigurationsbefore callingActivity#finish().Why it was changed
It seems like
Activity#finish()would "persist" across configuration change. Meaning, if we callfinish()on Activity A1 while it's being destroyed and replaced by Activity A2 because of configuration change, A2 will end up affected by the request.