Improve the accuracy of auto-captured place visits #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrHadiSatrio
force-pushed
the
feature/improved_autocapture
branch
from
437adc2 to
d92aad3
Compare
The `beenHereRecently` check was happening before the place was corrected to a nearby known place. This could lead to duplicate visits being captured for a single day, which we don't want.
Add the ability for coordinates to report their accuracy in meters.
Add a new check to skip auto-capturing moments when the accuracy of the coordinates is greater than 50 meters.
Refactor the auto-capture vicinity threshold to be dynamic based on the accuracy of the coordinates.
MrHadiSatrio
force-pushed
the
feature/improved_autocapture
branch
from
d92aad3 to
69b5c41
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
This patch introduces a dynamic auto-capture vicinity threshold based on the accuracy of the coordinates. Auto-capture is now skipped if the coordinate accuracy is greater than 50 meters. Additionally, the place is corrected before checking for recency.
Why it was changed
These changes were implemented to improve the accuracy and efficiency of auto-capture (#313). The previous fixed threshold did not account for coordinate accuracy, potentially leading to duplicate moments being captured. By dynamically adjusting the threshold, we ensure that auto-capture is triggered only when the user is in close proximity to a known place. Correcting the place before the recency check ensures that the appropriate place is used in that check, further enhancing accuracy.