Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Don't truncate numbers in number input #207

Closed
2 tasks done
Soft-Bred opened this issue Feb 7, 2024 · 2 comments · Fixed by #216
Closed
2 tasks done

✨ Don't truncate numbers in number input #207

Soft-Bred opened this issue Feb 7, 2024 · 2 comments · Fixed by #216
Assignees
@MrKai77
Labels
Feature

Comments

@Soft-Bred
Copy link
Collaborator

Feature Request Description

Long values in the number counter get cut off. I don't think this should happen.

Screenshots

004380@2x

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single feature request (multiple feature requests should be reported individually)
@MrKai77
Copy link
Owner

MrKai77 commented Feb 7, 2024 •
edited
Loading

Yup, I actually did a lot of research on working around this SwiftUI limitation but to no avail :(

I believe that the best solution would be to make my own custom "Textbox with stepper" view, and then use that across all of Loop's settings. I might also be able to integrate a slider onto this reusable view, so that everyone can get varying levels of exact customizability if needed.

@MrKai77 MrKai77 self-assigned this Feb 7, 2024
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Initial self-made stepper
658f41c
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Make textbox a popover
1776f5c
@MrKai77 MrKai77 linked a pull request Feb 16, 2024 that will close this issue
✨ #207 Don't truncate numbers in number input #216
Merged
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Put description beneath slider
df077df
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Replace all sliders in radial menu
94d4cfb
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Replace all sliders in preview window
48a84d8
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Replace all sliders in custom window sizes
a62bb4f
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Finish replacing all sliders
3916b6f
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Increase max number of decimal places
c9da372
MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
✨ #207 Remove TODO comment
cbb32d2
@MrKai77
Copy link
Owner

MrKai77 commented Feb 16, 2024

It is finally done! Here's a quick preview clip:
https://github.com/MrKai77/Loop/assets/68963405/b63aa93f-7f55-473b-a0e5-c295b2bfeaec

As well as a build:
Loop.zip

Let me know if there's anything to be improved!

MrKai77 added a commit that referenced this issue Feb 16, 2024
@MrKai77
🔀 Merge pull request #216 from `MrKai77/207-dont-truncate-numbers-in-…
204f133 
…number-input`

✨ #207 Don't truncate numbers in number input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrKai77 MrKai77

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ #207 Don't truncate numbers in number input MrKai77/Loop
2 participants
@Soft-Bred @MrKai77