Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Custom window size isn't respected/remembered #386

Closed
2 tasks done
Zabriskije opened this issue Jun 10, 2024 · 4 comments
Closed
2 tasks done

🐞 Custom window size isn't respected/remembered #386

Zabriskije opened this issue Jun 10, 2024 · 4 comments
Labels

Comments

@Zabriskije
Copy link
Contributor

Bug Description

When using the Custom option, the window size is not respected/remembered. Happens both with pixels and percentages.

Steps To Reproduce

  • Add a new Custom key bind
  • Modify the pixel/percentage values
  • Click on the slider again

Expected Behavior

The entered values should remain the same.

Actual Behavior

The entered values change when clicked again.

Screenshots

values

MacOS Version

Sonoma 14.5 (23F79)

Loop Version

Version 1.0.0-beta.15 (817)

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@SenpaiHunters
Copy link
Collaborator

SenpaiHunters commented Jun 10, 2024

Can you explain this issue(s) more? As what i can see, the issue is not shown, if you're editing the value, of course, it'll change. As currently, it looks like you're manually editing it as when it's clicked back in the same value is hosted there.

EDIT: This might be an issue (even though i am blind), and if it is, it's fixed in an upcoming build

@MrKai77
Copy link
Owner

MrKai77 commented Jun 11, 2024

Hey @Zabriskije!
Here's a dev build with the new settings window, which does fix this issue :)
Loop.zip

It is almost ready for a little update in #297 too!

@MrKai77 MrKai77 added the Bug label Jun 11, 2024 — with Linear
@Zabriskije
Copy link
Contributor Author

Can you explain this issue(s) more? As what i can see, the issue is not shown, if you're editing the value, of course, it'll change. As currently, it looks like you're manually editing it as when it's clicked back in the same value is hosted there.

EDIT: This might be an issue (even though i am blind), and if it is, it's fixed in an upcoming build

Yeah, I should have cropped down the GIF, it's hard to see here.
If you input – let's say – 950, the value is shown as 960 if you click again.
 

Hey @Zabriskije! Here's a dev build with the new settings window, which does fix this issue :) Loop.zip

It is almost ready for a little update in #297 too!

Nice! I love the text animation.
I didn't know if this was worth opening an issue since I knew the new settings window was coming, but I'm glad it's all solved.

@SenpaiHunters
Copy link
Collaborator

Thanks for reporting the issue, @Zabriskije as Kai gave you, it should be fixed now! Any more issues, with this new version or previous, you're always free to make an issue!

@MrKai77 MrKai77 closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants