Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Popup to allow screen recording, even if animations are off #42

Closed
kekscode opened this issue Sep 26, 2023 · 2 comments · Fixed by #44
Closed

🐛 Popup to allow screen recording, even if animations are off #42

kekscode opened this issue Sep 26, 2023 · 2 comments · Fixed by #44
Assignees
@MrKai77
Labels
Bug

Comments

@kekscode
Copy link

Bug Description

If accessibility is allowed but screen recording is not and the feature screen recording needs is turned off, every movement action pops up the dialogue to enable screen recording.

Steps To Reproduce

  1. Allow accessibility access but not screen recording
  2. Use Loop

Expected Behavior

No popups

Actual Behavior

Popups after every action.

Screenshots

No response

MacOS Version

13.6 (22G120)

Loop version

1.0.0-beta.10 (brew)

Additional Context

No response
@kekscode kekscode added the Bug label Sep 26, 2023
@MrKai77 MrKai77 self-assigned this Sep 26, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Sep 26, 2023 •
edited
Loading

Oh wow, thank you so much for reporting this! I thought I had tested this but it seems like I may have forgotten!
This is really important, so I'll try and fix this today! Sorry for the inconvenience! 🙇

MrKai77 added a commit that referenced this issue Sep 26, 2023
@MrKai77
🐛 #42 Only request screen recording access if needed
f4cab8a
@MrKai77
Copy link
Owner

MrKai77 commented Sep 26, 2023

Here's a fixed build: Loop.zip
Please let me know if you face any other issues!

@MrKai77 MrKai77 linked a pull request Sep 26, 2023 that will close this issue
🐛 #42 Only request screen recording access if needed #44
Merged
MrKai77 added a commit that referenced this issue Sep 26, 2023
@MrKai77
🔀 Merge pull request #44 from `MrKai77/42-popup-to-allow-screen-recor…
9f8cdcd 
…ding-even-if-animations-are-off`

🐛 #42 Only request screen recording access if needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrKai77 MrKai77

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 #42 Only request screen recording access if needed MrKai77/Loop
2 participants
@kekscode @MrKai77