Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SettingTab enum type #290

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Add SettingTab enum type #290

merged 4 commits into from
Mar 29, 2024

Conversation

phlpsong
Copy link
Contributor

Define an enum SettingTab to replace the current hardcode tab index

MrKai77
MrKai77 requested changes Mar 29, 2024
View reviewed changes
MrKai77
MrKai77 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Owner

@MrKai77 MrKai77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@MrKai77 MrKai77 merged commit 7965a29 into MrKai77:develop Mar 29, 2024
@phlpsong phlpsong deleted the tab-enum branch March 30, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKai77 MrKai77 MrKai77 approved these changes

Assignees

@phlpsong phlpsong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phlpsong @MrKai77