Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSchema- Empty comments are not parsed correctly #28

Closed
trubea08 opened this issue Jan 31, 2024 · 1 comment
Closed

getSchema- Empty comments are not parsed correctly #28

trubea08 opened this issue Jan 31, 2024 · 1 comment

Comments

@trubea08
Copy link

trubea08 commented Jan 31, 2024 •
edited
Loading

Empty comments are not closed correctly and take the next node as text. Schema is parsed with function getSchema.
Empty comments are added to the schema:
image

Instead of an empty string the next field is taken as comment text and the field is not added as property:
image
@trubea08 trubea08 changed the title getSchema - Empty comments are not parsed correctly #src/getSchema.ts - Empty comments are not parsed correctly Jan 31, 2024
@trubea08 trubea08 changed the title #src/getSchema.ts - Empty comments are not parsed correctly [getSchema](https://github.com/MrLeebo/prisma-ast/blob/main/src/getSchema.ts) - Empty comments are not parsed correctly Jan 31, 2024
@trubea08 trubea08 changed the title [getSchema](https://github.com/MrLeebo/prisma-ast/blob/main/src/getSchema.ts) - Empty comments are not parsed correctly getSchema- Empty comments are not parsed correctly Jan 31, 2024
MrLeebo added a commit that referenced this issue Feb 1, 2024
@MrLeebo
fix: resolves #28 by preventing comments from breaking into the next …
312f674 
…line
@MrLeebo MrLeebo closed this as completed in 866167d Feb 1, 2024
@MrLeebo
Copy link
Owner

MrLeebo commented Feb 1, 2024

@trubea08 thanks for reporting this bug! I have published v0.8.1 with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrLeebo @trubea08