preparation of new skins #47
Conversation
fix skin.pm3 typo
Script like skinshortcuts provide xml includes to build dynamic menus. Instead of modifiying files in the skin directory, let the scripts generate a custom xml file in the addon_data folder of the skin. Much safer than the current approach and also fixes MrMc compatability with these scripts.
|
sorry for the typo btw :-) |
This will fix the library nodes tree when services (plex/emby) are active.
|
Have not forgotten :) Working on getting 3.6.1 released |
|
no rush |
especially essential for the usecase where widgets are loading onto the homescreen using VFS paths like services://movies/recentlyaddedmovies
|
OK, also managed to fix the VFS usecases for widgets with services:// as rambled in my latest mail. |
Retrieve all ratings from plex and set them on the listitem's properties.
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes" ?> | |||
| <node order="3" type="folder" visible="!Library.HasContent(Music) + Library.HasServices"> | |||
There was a problem hiding this comment.
Library.HasServices has been made redundant from 3.7.0, Library.HasContent(xxxx) will take care of plex and emby music (or tvshow/movies) content as well
There was a problem hiding this comment.
Library.HasServices will always return false from now on... not sure if that ruins any of your plans in this commit :(
if it does, let me know and we can work out some way to accommodate it
There was a problem hiding this comment.
I think ^^ is causing the issues in 3.7.0 testflight... Library.HasServices is no more, and Library.HasContent(xxx) will return if Plex and Emby services exist.
I dont get anything for inProgress movies when only local database is enabled and no plex/emby data base available.
|
skin.script.skinshortcuts 1.0.17 is ok with this ? |
|
No, I am almost finished with an updated version of skinshortcuts. These are just the preparations of the MrMc codebase for having the skinshortcuts customizations in userdata instead of skindata and some other small fixes with the Plex integration I stumbled on. |
|
ahh, ok. so pull this in and wait ? |
|
Yes, please. Later this week I’ll do a follow up with the other changes |
as discussed by mail, this is the first step in adding support for skins that use skinshortcuts.