Speech sounds for carbon mobs work on tongue rather than species. #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMelbert
reviewed
Jan 26, 2025
maplestation_modules/code/modules/mob/living/speech_and_radio_sounds.dm
Outdated
Show resolved
Hide resolved
maplestation_modules/code/modules/mob/living/speech_and_radio_sounds.dm
Outdated
Show resolved
Hide resolved
maplestation_modules/code/modules/mob/living/speech_and_radio_sounds.dm
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah, this PR makes the speech sound work on tongues rather than hardcoded getters for every species.
This means you can take out someone's tongue, replace it with another species' tongue and get those speech sounds instead!
Also makes it way more easily vareditable for admins and coder/sound design testing.