Create dataset generation tests #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will rebase and modify after #12 is merged |
jeffbrennan
force-pushed
the
create_dataset_generation_tests
branch
from
63471de to
c90a7e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #10
a couple of things before merging
1 - I noticed the file generated from cargo run -- --n 1000 --k 10 --nas 10 --seed 591 created a file named "G1_1e3_1e3_10_10.csv" when I would have expected "G1_1e3_1e1_10_10.csv"
2 - need to test using cargo build instead of cargo run
3 - need to test using pyo3 instead of subprocess