Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][CI] Building system of farsante #19

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

SemyonSinchenko
Copy link
Collaborator

  • replace poetry by maturin
  • introduce Makefile for simplify life of devs
  • add a maturin action
  • refactor the project to the recommended structure
  • redefine dependencies as pure pyproject

(see PyO3/maturin#490 for details)

On branch 18-maturin_build
Changes to be committed:
new file: .github/workflows/release.yaml
modified: .gitignore
renamed: h2o-data-rust/Cargo.lock -> Cargo.lock
renamed: h2o-data-rust/Cargo.toml -> Cargo.toml
new file: Makefile
deleted: h2o-data-rust/README.md
modified: poetry.lock
modified: pyproject.toml
renamed: farsante/init.py -> python/farsante/init.py
renamed: farsante/h2o_dataset_create.py -> python/farsante/h2o_dataset_create.py
renamed: farsante/h2o_dataset_create_all.py -> python/farsante/h2o_dataset_create_all.py
renamed: farsante/pandas_dfs.py -> python/farsante/pandas_dfs.py
renamed: farsante/pandas_generators.py -> python/farsante/pandas_generators.py
renamed: farsante/pyspark_dfs.py -> python/farsante/pyspark_dfs.py
renamed: farsante/pyspark_generators.py -> python/farsante/pyspark_generators.py
renamed: h2o-data-rust/src/generators.rs -> src/generators.rs
renamed: h2o-data-rust/src/helpers.rs -> src/helpers.rs
renamed: h2o-data-rust/src/lib.rs -> src/lib.rs
renamed: h2o-data-rust/src/main.rs -> src/main.rs

- replace poetry by maturin
- introduce Makefile for simplify life of devs
- add a maturin action
- refactor the project to the recommended structure
- redefine dependencies as pure pyproject

(see PyO3/maturin#490 for details)

 On branch 18-maturin_build
 Changes to be committed:
	new file:   .github/workflows/release.yaml
	modified:   .gitignore
	renamed:    h2o-data-rust/Cargo.lock -> Cargo.lock
	renamed:    h2o-data-rust/Cargo.toml -> Cargo.toml
	new file:   Makefile
	deleted:    h2o-data-rust/README.md
	modified:   poetry.lock
	modified:   pyproject.toml
	renamed:    farsante/__init__.py -> python/farsante/__init__.py
	renamed:    farsante/h2o_dataset_create.py -> python/farsante/h2o_dataset_create.py
	renamed:    farsante/h2o_dataset_create_all.py -> python/farsante/h2o_dataset_create_all.py
	renamed:    farsante/pandas_dfs.py -> python/farsante/pandas_dfs.py
	renamed:    farsante/pandas_generators.py -> python/farsante/pandas_generators.py
	renamed:    farsante/pyspark_dfs.py -> python/farsante/pyspark_dfs.py
	renamed:    farsante/pyspark_generators.py -> python/farsante/pyspark_generators.py
	renamed:    h2o-data-rust/src/generators.rs -> src/generators.rs
	renamed:    h2o-data-rust/src/helpers.rs -> src/helpers.rs
	renamed:    h2o-data-rust/src/lib.rs -> src/lib.rs
	renamed:    h2o-data-rust/src/main.rs -> src/main.rs
By switching to maturing-builds
we do not need poetry.lock anymore

 On branch 18-maturin_build
 Your branch is up to date with 'origin/18-maturin_build'.

 Changes to be committed:
	deleted:    poetry.lock
@SemyonSinchenko SemyonSinchenko added the enhancement New feature or request label Mar 10, 2024
@SemyonSinchenko SemyonSinchenko self-assigned this Mar 10, 2024
Copy link
Collaborator

@jeffbrennan jeffbrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The new project structure and naming should make development of non-h2o datasets much easier. After we merge I'll go through the docs and update where needed

@SemyonSinchenko SemyonSinchenko linked an issue Mar 10, 2024 that may be closed by this pull request
@SemyonSinchenko SemyonSinchenko merged commit aa42c75 into MrPowers:master Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build of python and rust parts in CI
2 participants