Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'urlSuffix' is better to be a configuration option. #35

Closed
xucongli1989 opened this issue Feb 9, 2023 · 6 comments · Fixed by #48
Closed

'urlSuffix' is better to be a configuration option. #35

xucongli1989 opened this issue Feb 9, 2023 · 6 comments · Fixed by #48
Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project

Comments

@xucongli1989
Copy link

Description

I think someone's Conluence home page is not start with /wiki/. Thanks!

Code

protected urlSuffix = '/wiki/rest/';

@MrRefactoring
Copy link
Owner

Hello @xucongli1989! Thanks for mentioning it. Needs to improve it

@MrRefactoring MrRefactoring added the enhancement Denotes a suggestion or request aimed at improving or adding new features to the project label Feb 9, 2023
@tschannik
Copy link

Hi,

I'm trying to use the library but my confluence instance doesn't use the wiki suffix. Is there a way or configuration currently usable to get around that?

@xucongli1989
Copy link
Author

@tschannik , you can try this:

const client = new ConfluenceClient({...})
client.urlSuffix = "/rest/"

@tschannik
Copy link

@xucongli1989

That works :) would be also nice if it could be configurable in the constructor. I could open a PR if i have time later 👍

@tschannik
Copy link

#41

@MrRefactoring MrRefactoring linked a pull request Mar 26, 2023 that will close this issue
@MrRefactoring MrRefactoring linked a pull request May 21, 2023 that will close this issue
MrRefactoring added a commit that referenced this issue May 21, 2023
MrRefactoring added a commit that referenced this issue May 21, 2023
MrRefactoring added a commit that referenced this issue May 21, 2023
* #35 `apiPrefix` now configurable

* #35 serverClient prefix setup
@MrRefactoring
Copy link
Owner

Will be added with V2 API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project
Projects
None yet
3 participants