Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set serializeIdsAsStrings to true for all of endpoint use this. #47

Closed
Tracked by #43
MrRefactoring opened this issue May 21, 2023 · 0 comments
Closed
Tracked by #43
Assignees
Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project good first issue Highlights beginner-friendly tasks, ideal for those looking to contribute for the first time help wanted Signals that additional assistance or expertise is needed on a particular issue or feature

Comments

@MrRefactoring
Copy link
Owner

MrRefactoring commented May 21, 2023

What we have

A lot of endpoints added serializeIdsAsStrings property. Example

What should be done

  1. For all endpoints serializeIdsAsStrings setted to true by default
  2. serializeIdsAsStrings removed from all Models and Parameters

Example what I want to see

Was

    const config: RequestConfig = {
      url: `/attachments/${parameters.id}`,
      method: 'GET',
      params: {
        version: parameters.version,
        'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
      },
    };

Now

    const config: RequestConfig = {
      url: `/attachments/${parameters.id}`,
      method: 'GET',
      params: {
        version: parameters.version,
        'serialize-ids-as-strings': true,
      },
    };
@MrRefactoring MrRefactoring added this to the Version 2 API support milestone May 21, 2023
@MrRefactoring MrRefactoring added enhancement Denotes a suggestion or request aimed at improving or adding new features to the project help wanted Signals that additional assistance or expertise is needed on a particular issue or feature good first issue Highlights beginner-friendly tasks, ideal for those looking to contribute for the first time labels May 21, 2023
@MrRefactoring MrRefactoring self-assigned this May 21, 2023
MrRefactoring added a commit that referenced this issue May 21, 2023
MrRefactoring added a commit that referenced this issue May 21, 2023
* #47 'serialize-ids-as-strings' set to true by default

* #47 build fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project good first issue Highlights beginner-friendly tasks, ideal for those looking to contribute for the first time help wanted Signals that additional assistance or expertise is needed on a particular issue or feature
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant