Closed
Description
In the getPageInlineComments function, parameters with a dash (-) are used. The proposal is to replace these dash-cased
parameters with camelCase
.
The function currently looks like this:
async getPageInlineComments<T = Models.Pagination<Models.PageInlineComment>>(
parameters: Parameters.GetPageInlineComments,
callback?: Callback<T>,
): Promise<void | T> {
const config: RequestConfig = {
url: `/pages/${parameters.id}/inline-comments`,
method: 'GET',
params: {
'body-format': parameters['body-format'],
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': true,
},
};
return this.client.sendRequest(config, callback);
}
Expected function look:
async getPageInlineComments<T = Models.Pagination<Models.PageInlineComment>>(
parameters: Parameters.GetPageInlineComments,
callback?: Callback<T>,
): Promise<void | T> {
const config: RequestConfig = {
url: `/pages/${parameters.id}/inline-comments`,
method: 'GET',
params: {
'body-format': parameters.bodyFormat,
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': true,
},
};
return this.client.sendRequest(config, callback);
}
Metadata
Metadata
Assignees
Labels
Projects
Status
Done