Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#47 'serialize-ids-as-strings' set to true by default #50

Merged
merged 2 commits into from
May 21, 2023
Merged

#47 'serialize-ids-as-strings' set to true by default #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfc6ce0
#47 'serialize-ids-as-strings' set to true by default
MrRefactoring May 21, 2023
797806d
#47 build fixes
MrRefactoring May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/version2/attachment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class Attachment {
method: 'GET',
params: {
version: parameters.version,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -78,7 +78,7 @@ export class Attachment {
mediaType: parameters.mediaType,
filename: parameters.filename,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -120,7 +120,7 @@ export class Attachment {
mediaType: parameters.mediaType,
filename: parameters.filename,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -160,7 +160,7 @@ export class Attachment {
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -202,7 +202,7 @@ export class Attachment {
mediaType: parameters.mediaType,
filename: parameters.filename,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down
17 changes: 10 additions & 7 deletions src/version2/blogPost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ export class BlogPost {
* **[Permissions](https://confluence.atlassian.com/x/_AozKw) required**: Permission to access the Confluence site
* ('Can use' global permission). Only blog posts that the user has permission to view will be returned.
*/
async getBlogPosts<T = Models.Pagination<Models.BlogPost>>(parameters?: Parameters.GetBlogPosts, callback?: never): Promise<T>;
async getBlogPosts<T = Models.Pagination<Models.BlogPost>>(
parameters?: Parameters.GetBlogPosts,
callback?: never,
): Promise<T>;
async getBlogPosts<T = Models.Pagination<Models.BlogPost>>(
parameters?: Parameters.GetBlogPosts,
callback?: Callback<T>,
Expand All @@ -39,7 +42,7 @@ export class BlogPost {
'body-format': parameters?.bodyFormat,
cursor: parameters?.cursor,
limit: parameters?.limit,
'serialize-ids-as-strings': parameters?.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -75,7 +78,7 @@ export class BlogPost {
url: '/blogposts',
method: 'POST',
params: {
'serialize-ids-as-strings': parameters?.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -110,7 +113,7 @@ export class BlogPost {
'body-format': parameters['body-format'],
'get-draft': parameters['get-draft'],
version: parameters.version,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -142,7 +145,7 @@ export class BlogPost {
url: `/blogposts/${parameters.id}`,
method: 'PUT',
params: {
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -206,7 +209,7 @@ export class BlogPost {
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -249,7 +252,7 @@ export class BlogPost {
'body-format': parameters.bodyFormat,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down
9 changes: 6 additions & 3 deletions src/version2/children.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ export class Children {
* **[Permissions](https://confluence.atlassian.com/x/_AozKw) required**: Permission to access the Confluence site
* ('Can use' global permission). Only pages that the user has permission to view will be returned.
*/
async getChildPages<T = Models.Pagination<Models.ChildPage>>(parameters: Parameters.GetChildPages, callback?: never): Promise<T>;
async getChildPages<T = Models.Pagination<Models.ChildPage>>(
parameters: Parameters.GetChildPages,
callback?: never,
): Promise<T>;
async getChildPages<T = Models.Pagination<Models.ChildPage>>(
parameters: Parameters.GetChildPages,
callback?: Callback<T>,
Expand All @@ -37,7 +40,7 @@ export class Children {
cursor: parameters.cursor,
limit: parameters.limit,
sort: parameters.sort,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -79,7 +82,7 @@ export class Children {
cursor: parameters.cursor,
limit: parameters.limit,
sort: parameters.sort,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down
24 changes: 12 additions & 12 deletions src/version2/comment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class Comment {
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -82,7 +82,7 @@ export class Comment {
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -125,7 +125,7 @@ export class Comment {
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -168,7 +168,7 @@ export class Comment {
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -205,7 +205,7 @@ export class Comment {
url: '/footer-comments',
method: 'POST',
params: {
'serialize-ids-as-strings': parameters?.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
data: {
blogPostId: parameters?.blogPostId,
Expand Down Expand Up @@ -248,7 +248,7 @@ export class Comment {
params: {
'body-format': parameters['body-format'],
version: parameters.version,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -283,7 +283,7 @@ export class Comment {
url: `/footer-comments/${parameters.commentId}`,
method: 'PUT',
params: {
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
data: {
version: parameters.version,
Expand Down Expand Up @@ -356,7 +356,7 @@ export class Comment {
sort: parameters.sort,
cursor: parameters.cursor,
limit: parameters.limit,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -397,7 +397,7 @@ export class Comment {
url: '/inline-comments',
method: 'POST',
params: {
'serialize-ids-as-strings': parameters?.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
data: {
blogPostId: parameters?.blogPostId,
Expand Down Expand Up @@ -441,7 +441,7 @@ export class Comment {
params: {
'body-format': parameters['body-format'],
version: parameters.version,
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
};

Expand Down Expand Up @@ -476,7 +476,7 @@ export class Comment {
url: `/inline-comments/${parameters.commentId}`,
method: 'PUT',
params: {
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
},
data: {
version: parameters.version,
Expand Down Expand Up @@ -546,7 +546,7 @@ export class Comment {
url: `/inline-comments/${parameters.id}/children`,
method: 'GET',
params: {
'serialize-ids-as-strings': parameters.serializeIdsAsStrings,
'serialize-ids-as-strings': true,
'body-format': parameters['body-format'],
sort: parameters.sort,
cursor: parameters.cursor,
Expand Down
Loading