Set a better redraw time to avoid High CPU Usage #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I personally believe this should be up to the user, but have no problem with simply changing the default to a more reasonable value. Does vtop have existing logic to load configuration files? |
|
It's possible to make it configurable, but I don't see a reason to collect information every 100ms or 5 minutes. 1 second is enough, but if needed I can change to make it configurable. |
|
I'm definitely in favor of configurability (I would love to be able to customize this), but I suppose that change could come later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues #82 and #55
Note: This fix just changed a hard-coded value. Need to discuss if
this value shouldn't be parametrized by the user via command-line