Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.9.33 解析 CQ 码时 url 未进行反转义 #458

Closed
Tsuk1ko opened this issue Dec 3, 2020 · 1 comment
Closed

v0.9.33 解析 CQ 码时 url 未进行反转义 #458

Tsuk1ko opened this issue Dec 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Tsuk1ko
Copy link

Tsuk1ko commented Dec 3, 2020

环境信息

go-cqhttp版本: v0.9.33
运行环境: windows_amd64
连接方式: any

bug内容

发送[CQ:image,file=http://xxx/xxx.jpg?a=1&b=2]时，理应发送http://xxx/xxx.jpg?a=1&b=2，而目前发送的仍为http://xxx/xxx.jpg?a=1&b=2，没有对 url 进行反转义

这个问题我以前在 #9 中提到过，是否是 v0.9.33 重构 CQ 码解析时漏掉了该反转义逻辑？
@Mrs4s Mrs4s added the bug Something isn't working label Dec 3, 2020
@Mrs4s Mrs4s closed this as completed in a4ec407 Dec 3, 2020
@Mrs4s
Copy link
Owner

Mrs4s commented Dec 3, 2020

非常抱歉忘记value的反转义了...
已修复在 https://github.com/Mrs4s/go-cqhttp/actions/runs/397492420

bephbin51695 added a commit to bephbin51695/go-cqhttp that referenced this issue Dec 31, 2020
@bephbin51695 @Mrs4s
@dfaofeng @brownchow @wdvxdr1123 @shirokurakana @kanrichan @Ink-33 @ishkong @yanyongyu
Dev update (#2)
e339be1 
* update MiraiGo.

* update README.md

* fix:Dockerfile增加代理源

* remove mkdir, add set -ex

* update MiraiGo.

* update MiraiGo.

* feature new cqcode converter

* more error message.

* update MiraiGo.

* clear code.

* fix Mrs4s#455.

* update MiraiGo.

* try to fix Mrs4s#422.

* update MiraiGo.

* update MiraiGo.

* update MiraiGo.

* fix Mrs4s#458.

* feature remove test for ocr_image api.

* optimization cqcode converter.

* ⚡ improve event filter

* remove convert

* feat get group info no cache

* update go-silk

* feature pprof service.

* fix msg.

* more info for 当前上网环境异常. close Mrs4s#465.

* 补充并整理文档

* update MiraiGo.

* add stacktrace on panic.

* fix pprof.

* improve doc

* improve doc

* update docs

* support event recover.

* feature auto fragment.

* update MiraiGo.

* update MiraiGo.

* fix ios record

* [Break Change]feature: key entry without echoing
Remove unexpected "CR" & "LF" while scaning key. This will cause the previous encrypted password unusable.

* update MiraiGo.

* update MiraiGo.

* update MiraiGo.

* update ISSUE_TEMPLATE.

* update MiraiGo.

* feature get_group_at_all_remain.

* support old coolq data path. Mrs4s#499

* update raw.

* fix Mrs4s#501.

* fix issue of get_msg image url empty. Mrs4s#503

* update doc.

* feature fix url & update doc.

* update MiraiGo.

* update MiraiGo.

* websocket not found method

* fix lock

* add user group.

* update doc.

* Update README.md

* 📝 update readme

* group forward msg套娃

* update MiraiGo

* feature set_group_anonymous_ban.

* update MiraiGo.

* fix onebot protocol.

* feature solve silder.

Co-authored-by: Mrs4s <mrs4sxiaoshi@gmail.com>
Co-authored-by: daofeng2015 <jcb20150301@gmail.com>
Co-authored-by: brownchow <8622915+brownchow@users.noreply.github.com>
Co-authored-by: Mrs4s <1844812067@qq.com>
Co-authored-by: wdvxdr <wdvxdr@foxmail.com>
Co-authored-by: shirokurakana <admin@thdog.moe>
Co-authored-by: Yiwen-Chan <yiwen_chan@foxmail.com>
Co-authored-by: Ink-33 <quhyu@qq.com>
Co-authored-by: ishkong <i@shkong.cc>
Co-authored-by: yanyongyu <yanyongyu_1@126.com>
bephbin51695 added a commit to bephbin51695/go-cqhttp that referenced this issue Dec 31, 2020
@bephbin51695 @dfaofeng
@Mrs4s @brownchow @wdvxdr1123 @shirokurakana @kanrichan @Ink-33 @ishkong @yanyongyu @mzdluo123
update (#3)
10faa93 
* fix:Dockerfile增加代理源

* remove mkdir, add set -ex

* update MiraiGo.

* update MiraiGo.

* feature new cqcode converter

* more error message.

* update MiraiGo.

* clear code.

* fix Mrs4s#455.

* update MiraiGo.

* try to fix Mrs4s#422.

* update MiraiGo.

* update MiraiGo.

* update MiraiGo.

* fix Mrs4s#458.

* feature remove test for ocr_image api.

* optimization cqcode converter.

* ⚡ improve event filter

* remove convert

* feat get group info no cache

* update go-silk

* feature pprof service.

* fix msg.

* more info for 当前上网环境异常. close Mrs4s#465.

* 补充并整理文档

* update MiraiGo.

* add stacktrace on panic.

* fix pprof.

* improve doc

* improve doc

* update docs

* support event recover.

* feature auto fragment.

* update MiraiGo.

* update MiraiGo.

* fix ios record

* [Break Change]feature: key entry without echoing
Remove unexpected "CR" & "LF" while scaning key. This will cause the previous encrypted password unusable.

* update MiraiGo.

* update MiraiGo.

* update MiraiGo.

* update ISSUE_TEMPLATE.

* update MiraiGo.

* feature get_group_at_all_remain.

* support old coolq data path. Mrs4s#499

* update raw.

* fix Mrs4s#501.

* fix issue of get_msg image url empty. Mrs4s#503

* update doc.

* feature fix url & update doc.

* update MiraiGo.

* update MiraiGo.

* websocket not found method

* fix lock

* add user group.

* update doc.

* Update README.md

* 📝 update readme

* group forward msg套娃

* update MiraiGo

* feature set_group_anonymous_ban.

* update MiraiGo.

* fix onebot protocol.

* feature solve silder.

* fix silder.

* update doc.

* update.

* fix panic.

* update doc.

* Update quick_start.md

* update MiraiGo.

* update MiraiGo.

Co-authored-by: daofeng2015 <jcb20150301@gmail.com>
Co-authored-by: Mrs4s <mrs4sxiaoshi@gmail.com>
Co-authored-by: brownchow <8622915+brownchow@users.noreply.github.com>
Co-authored-by: Mrs4s <1844812067@qq.com>
Co-authored-by: wdvxdr <wdvxdr@foxmail.com>
Co-authored-by: shirokurakana <admin@thdog.moe>
Co-authored-by: Yiwen-Chan <yiwen_chan@foxmail.com>
Co-authored-by: Ink-33 <quhyu@qq.com>
Co-authored-by: ishkong <i@shkong.cc>
Co-authored-by: yanyongyu <yanyongyu_1@126.com>
Co-authored-by: HelloWorld <mzdluo123@foxmail.com>
bephbin51695 added a commit to bephbin51695/go-cqhttp that referenced this issue Feb 1, 2021
@bephbin51695 @dfaofeng
@Mrs4s @brownchow @wdvxdr1123 @shirokurakana @kanrichan @Ink-33 @ishkong @yanyongyu @mzdluo123 @kokororin @Diving-Fish @01101sam @xuthus5
update (#5)
8175003 
* fix:Dockerfile增加代理源

* remove mkdir, add set -ex

* update MiraiGo.

* update MiraiGo.

* feature new cqcode converter

* more error message.

* update MiraiGo.

* clear code.

* fix Mrs4s#455.

* update MiraiGo.

* try to fix Mrs4s#422.

* update MiraiGo.

* update MiraiGo.

* update MiraiGo.

* fix Mrs4s#458.

* feature remove test for ocr_image api.

* optimization cqcode converter.

* ⚡ improve event filter

* remove convert

* feat get group info no cache

* update go-silk

* feature pprof service.

* fix msg.

* more info for 当前上网环境异常. close Mrs4s#465.

* 补充并整理文档

* update MiraiGo.

* add stacktrace on panic.

* fix pprof.

* improve doc

* improve doc

* update docs

* support event recover.

* feature auto fragment.

* update MiraiGo.

* update MiraiGo.

* fix ios record

* [Break Change]feature: key entry without echoing
Remove unexpected "CR" & "LF" while scaning key. This will cause the previous encrypted password unusable.

* update MiraiGo.

* update MiraiGo.

* update MiraiGo.

* update ISSUE_TEMPLATE.

* update MiraiGo.

* feature get_group_at_all_remain.

* support old coolq data path. Mrs4s#499

* update raw.

* fix Mrs4s#501.

* fix issue of get_msg image url empty. Mrs4s#503

* update doc.

* feature fix url & update doc.

* update MiraiGo.

* update MiraiGo.

* websocket not found method

* fix lock

* add user group.

* update doc.

* Update README.md

* 📝 update readme

* group forward msg套娃

* update MiraiGo

* feature set_group_anonymous_ban.

* update MiraiGo.

* fix onebot protocol.

* feature solve silder.

* fix silder.

* update doc.

* update.

* fix panic.

* update doc.

* Update quick_start.md

* update MiraiGo.

* update MiraiGo.

* update (#4)

* feat send CQ:forward

* drop getlantern/go-update

* tidy

* Update cqhttp.md

* Update cqhttp.md

* update MiraiGo.

* fix none msg

* fix typo

* feature multi-threading download & fix invalid file.

* fix message type.

* update MiraiGo.

* fix typo.

* update MiraiGo.

* update doc.

* update MiraiGo.

* fix ptt.

* fix reconnect

* feature download_file.

* update doc.

* fix reconnect loop on account banned.

* drop  go-silk

* encode mp4

* feat CQ:video

* update docs

* fix video

* fix private video

* fix typo

* update MiraiGo.

* update MiraiGo & fix user-agent & fix file lock.

* fix file close

* support video cache file

* Fix misspell

* update MiraiGo & qid support.

* update MiraiGo.

* fix message.

* fix multi-threading upload.

* fix thumb.

* fix show pic error.

* fix forward img & video upload.

* fix show pic error.

* fix forward img & video upload.

* fix Mrs4s#558

* add codec/codec_unsupported.go

* Update github action

* Update github action

* fix build

* fix Mrs4s#557 & remove some goto

* fix codec path

* fix Mrs4s#561

* update MiraiGo.

* Try force transcoding

Attempt to brute force ffmpeg transcoding after failure

* update go.mod

* fix: golangci-lint gosimple

* update import

* fix: golangci-lint ineffassign

* fix: golangci-lint staticcheck

* fix: golangci-lint errcheck

* fix get gender of group member

* fix get gender of group member

* fix golint

* Make send_group_forward_msg can use on get_msg

理论上这个是正常支持的, Fix Mrs4s#542

* Added unbreakable feature
- Reply message customizable
- Forward message able to customize time

Signed-off-by: Sam <lau.sam745033858@gmail.com>

* update string message

* update MiraiGo.

* fix Mrs4s#562.

* fix ua.

* feature get_group_msg_history.

* local log hook

* reset default config log_level

* log support print report_line

* fix Mrs4s#540.

* update MiraiGo.

* feature get_online_clients.

* doc update.

* feature client status updated event.

* update MiraiGo. fix Mrs4s#586

* update MiraiGo. fix Mrs4s#577

* update MiraiGo.

* update doc.

* fix

* isFastStart setting appiled to config.hjson gen

* Move isFastStart outside

Co-authored-by: wdvxdr <wdvxdr@foxmail.com>
Co-authored-by: Mrs4s <mrs4sxiaoshi@gmail.com>
Co-authored-by: ishkong <i@shkong.cc>
Co-authored-by: Mrs4s <1844812067@qq.com>
Co-authored-by: そら <ritsuka.sunny@gmail.com>
Co-authored-by: Ink33 <51873347+Ink-33@users.noreply.github.com>
Co-authored-by: Ink-33 <quhyu@qq.com>
Co-authored-by: Diving-Fish <dfyshisb@163.com>
Co-authored-by: sam01101 <lau.sam745033858@gmail.com>
Co-authored-by: xuthus5 <xuthus5@gmail.com>
Co-authored-by: xuye <xuye@pinquest.cn>

Co-authored-by: daofeng2015 <jcb20150301@gmail.com>
Co-authored-by: Mrs4s <mrs4sxiaoshi@gmail.com>
Co-authored-by: brownchow <8622915+brownchow@users.noreply.github.com>
Co-authored-by: Mrs4s <1844812067@qq.com>
Co-authored-by: wdvxdr <wdvxdr@foxmail.com>
Co-authored-by: shirokurakana <admin@thdog.moe>
Co-authored-by: Yiwen-Chan <yiwen_chan@foxmail.com>
Co-authored-by: Ink-33 <quhyu@qq.com>
Co-authored-by: ishkong <i@shkong.cc>
Co-authored-by: yanyongyu <yanyongyu_1@126.com>
Co-authored-by: HelloWorld <mzdluo123@foxmail.com>
Co-authored-by: そら <ritsuka.sunny@gmail.com>
Co-authored-by: Ink33 <51873347+Ink-33@users.noreply.github.com>
Co-authored-by: Diving-Fish <dfyshisb@163.com>
Co-authored-by: sam01101 <lau.sam745033858@gmail.com>
Co-authored-by: xuthus5 <xuthus5@gmail.com>
Co-authored-by: xuye <xuye@pinquest.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mrs4s @Tsuk1ko